Skip to contentSkip to conversation

Change in openvpn[master]: buffer: remove unused function buf_write_alloc_prepend

Openvpn-devel In review flichtenheld (Code Review) 2 participants 6 messages Aug 6, 2025 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1754490554000.I71981e39932cafe3fd68b475fdb81a8f20a3a547@...2715...

#1 lore raw

Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1134?usp=email

to review the following change.

Change subject: buffer: remove unused function buf_write_alloc_prepend
......................................................................

buffer: remove unused function buf_write_alloc_prepend

Change-Id I71981e39932cafe3fd68b475fdb81a8f20a3a547

---
M src/openvpn/buffer.h

1 file changed, 0 insertions(+), 6 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/34/1134/1

src/openvpn/buffer.h +0 -6
index 8d6bb64..6f15115 100644
@@ -644,12 +644,6 @@
 }
 
 static inline uint8_t *
-buf_write_alloc_prepend(struct buffer *buf, int size, bool prepend)
-{
-    return prepend ? buf_prepend(buf, size) : buf_write_alloc(buf, size);
-}
-
-static inline uint8_t *
 buf_read_alloc(struct buffer *buf, int size)
 {
     uint8_t *ret;

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1134?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547
Gerrit-Change-Number: 1134
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-MessageType: newchange

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1134?usp=email )

Change subject: buffer: remove unused function buf_write_alloc_prepend
......................................................................

Patch Set 1: Code-Review+2

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1134?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547
Gerrit-Change-Number: 1134
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Wed, 06 Aug 2025 14:42:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

#3 lore raw

PATCH 1/1 buffer: remove unused function buf_write_alloc_prepend

In reply to a message not in the archive

From: Frank Lichtenheld <[email protected]...>

Change-Id I71981e39932cafe3fd68b475fdb81a8f20a3a547

---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1134
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>

src/openvpn/buffer.h +0 -6
index 8d6bb64..6f15115 100644
@@ -644,12 +644,6 @@
 }
 
 static inline uint8_t *
-buf_write_alloc_prepend(struct buffer *buf, int size, bool prepend)
-{
-    return prepend ? buf_prepend(buf, size) : buf_write_alloc(buf, size);
-}
-
-static inline uint8_t *
 buf_read_alloc(struct buffer *buf, int size)
 {
     uint8_t *ret;
#4 lore raw

[Openvpn-devel] [PATCH applied] Re: buffer: remove unused function buf_write_alloc_prepend

"Remove unused function" is easy to review :-) - out it goes. BB and "git grep" confirm.

Your patch has been applied to the master branch.

commit 028846f0f73db0e598a8fcdb3d5578bb5920046c

Author: Frank Lichtenheld
Date:   Wed Aug 6 16:42:31 2025 +0200
     buffer: remove unused function buf_write_alloc_prepend

     Signed-off-by: Frank Lichtenheld <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg32565.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#5 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1134?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by cron2

Change subject: buffer: remove unused function buf_write_alloc_prepend
......................................................................

buffer: remove unused function buf_write_alloc_prepend

Change-Id I71981e39932cafe3fd68b475fdb81a8f20a3a547

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32565.html

---
M src/openvpn/buffer.h

1 file changed, 0 insertions(+), 6 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/34/1134/2

src/openvpn/buffer.h +0 -6
index ae783c6..1405667 100644
@@ -643,12 +643,6 @@
 }
 
 static inline uint8_t *
-buf_write_alloc_prepend(struct buffer *buf, int size, bool prepend)
-{
-    return prepend ? buf_prepend(buf, size) : buf_write_alloc(buf, size);
-}
-
-static inline uint8_t *
 buf_read_alloc(struct buffer *buf, int size)
 {
     uint8_t *ret;

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1134?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547
Gerrit-Change-Number: 1134
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset

#6 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1134?usp=email )

Change subject: buffer: remove unused function buf_write_alloc_prepend
......................................................................

buffer: remove unused function buf_write_alloc_prepend

Change-Id I71981e39932cafe3fd68b475fdb81a8f20a3a547

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg32565.html

---
M src/openvpn/buffer.h

1 file changed, 0 insertions(+), 6 deletions(-)
src/openvpn/buffer.h +0 -6
index ae783c6..1405667 100644
@@ -643,12 +643,6 @@
 }
 
 static inline uint8_t *
-buf_write_alloc_prepend(struct buffer *buf, int size, bool prepend)
-{
-    return prepend ? buf_prepend(buf, size) : buf_write_alloc(buf, size);
-}
-
-static inline uint8_t *
 buf_read_alloc(struct buffer *buf, int size)
 {
     uint8_t *ret;

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1134?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I71981e39932cafe3fd68b475fdb81a8f20a3a547
Gerrit-Change-Number: 1134
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged